feat(diagnostic): support minification error#10057
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
hardfist
reviewed
Apr 16, 2025
hardfist
previously approved these changes
Apr 16, 2025
CodSpeed Performance ReportMerging #10057 will not alter performanceComparing 🎉 Hooray!
|
4a62b0b to
2fdf384
Compare
chenjiahan
reviewed
Apr 23, 2025
chenjiahan
previously approved these changes
Apr 23, 2025
Contributor
Author
|
Holding off on this PR until it's fully discussed. |
2 tasks
2fdf384 to
d725078
Compare
d1cd205 to
7c80a27
Compare
7c80a27 to
cb515c1
Compare
Contributor
Author
|
Rebased cc @chenjiahan |
chenjiahan
approved these changes
May 28, 2025
Member
|
👍 |
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supports
StatsError.codeandStatsWarning.code. This is an rspack-specific API, which is not implemented in webpack.StatsErrorCodeis exported as a reference to code used in rspack.ChunkMinificationError: Generated when chunk minification encounters an errorChunkMinificationWarning: Generated when chunk minification encounters an warningModuleParseWarning: Generated when module parsing encounters an warningModuleParseError: Generated when module parsing encounters an errorModuleBuildError: Generated when module loader encounters an errorThe following example shows when minifcation encounters an error:
Its error code is
ChunkMinificationError.trivial changes: Normalize
parsing errorintoparse error. This follows webpack's naming convention, e.gModuleParseError.Note: There are a few snapshot changes due to a few newly added snapshot serializer.
Checklist